Async streaming iOS #599
Merged
Async streaming iOS #599
+433
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## async-streaming-core #599 +/- ##
========================================================
+ Coverage 89.72% 89.87% +0.14%
========================================================
Files 334 335 +1
Lines 19923 20273 +350
Branches 1956 1956
========================================================
+ Hits 17876 18220 +344
- Misses 2033 2039 +6
Partials 14 14 ☔ View full report in Codecov by Sentry. |
brocollie08
reviewed
Feb 21, 2025
| } | ||
|
|
||
| let asyncNodePluginPlugin = AsyncNodePluginPlugin() | ||
| let plugin = AsyncNodePlugin(plugins: [asyncNodePluginPlugin], resolve) |
There was a problem hiding this comment.
out of scope for the PR, but this constructor API is inconsistent across platforms
| XCTAssertEqual(expectedNode1Text, "chat message") | ||
|
|
||
| wait(for: [textExpectation2], timeout: 5) | ||
| XCTAssertEqual(expectedNode2Text, "chained chat message") |
nancywu1
reviewed
Feb 24, 2025
|
|
||
| wait(for: [textExpectation2], timeout: 5) | ||
| XCTAssertEqual(expectedNode2Text, "chained chat message") | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
can we add additional test using the callback mechanism using chat message similar to
There was a problem hiding this comment.
ty! added new callback tests for chatmessage
cehan-Chloe
force-pushed
the
async-streaming-ios
branch
from
3768255 to
60e5c52
Compare
nancywu1
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core update can be found here
demo app screenshot:
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
doc update in core pr
Release Notes
Player streaming enhancement for iOS
Changes